Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Translate ML - time series explorer #28066

Merged
merged 100 commits into from
Jan 14, 2019

Conversation

Nox911
Copy link
Contributor

@Nox911 Nox911 commented Jan 4, 2019

Translate ml -> public -> timeseriesexplorer

Issue: #25454

Guidline
Readme

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@pavel06081991 pavel06081991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally, works good

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@Nox911 Nox911 merged commit 9b3a216 into elastic:master Jan 14, 2019
@Nox911 Nox911 deleted the feature/translate-ml-timeseries_explorer branch January 14, 2019 07:44
Nox911 added a commit to Nox911/kibana that referenced this pull request Jan 14, 2019
* Translate timeseries explorer

* Fix issues

* Fix tslint errors

* Fix tslint error

* Fix test

* Update tests

* Fix tests

* Update snapshot

* Resolve issues from review comments

* Resolve issues from review comments
Nox911 added a commit that referenced this pull request Jan 14, 2019
* Translate timeseries explorer

* Fix issues

* Fix tslint errors

* Fix tslint error

* Fix test

* Update tests

* Fix tests

* Update snapshot

* Resolve issues from review comments

* Resolve issues from review comments
@Nox911
Copy link
Contributor Author

Nox911 commented Jan 14, 2019

6.x/6.7.0: 7d9b110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants