-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[i18n] Translate ML - time series explorer #28066
Merged
Nox911
merged 100 commits into
elastic:master
from
Nox911:feature/translate-ml-timeseries_explorer
Jan 14, 2019
Merged
[i18n] Translate ML - time series explorer #28066
Nox911
merged 100 commits into
elastic:master
from
Nox911:feature/translate-ml-timeseries_explorer
Jan 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
second merge
💚 Build Succeeded |
pavel06081991
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Tested locally, works good
peteharverson
requested changes
Jan 10, 2019
x-pack/plugins/ml/public/timeseriesexplorer/components/timeseries_chart/timeseries_chart.js
Show resolved
Hide resolved
x-pack/plugins/ml/public/timeseriesexplorer/components/forecasting_modal/forecasting_modal.js
Outdated
Show resolved
Hide resolved
...ins/ml/public/timeseriesexplorer/components/forecasting_modal/forecasting_modal_directive.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/ml/public/timeseriesexplorer/components/timeseries_chart/timeseries_chart.js
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
peteharverson
approved these changes
Jan 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded |
💚 Build Succeeded |
Nox911
added a commit
to Nox911/kibana
that referenced
this pull request
Jan 14, 2019
* Translate timeseries explorer * Fix issues * Fix tslint errors * Fix tslint error * Fix test * Update tests * Fix tests * Update snapshot * Resolve issues from review comments * Resolve issues from review comments
Nox911
added a commit
that referenced
this pull request
Jan 14, 2019
6.x/6.7.0: 7d9b110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate ml -> public -> timeseriesexplorer
Issue: #25454
Guidline
Readme